Re: 262e2d9d breaks linux-2.6.32.y

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 11, 2011 at 01:35:11PM +0300, Phil Carmody wrote:
> Greetings all.
> 
> This particular commit:
> """
> commit 262e2d9d559334e09bc80516132ea99d82f97b8c
> Author: Ajay Kumar Gupta <ajay.gupta@xxxxxx>
> Date:   Fri Jul 8 15:06:13 2011 +0530
> 
>     usb: musb: restore INDEX register in resume path
>     
>     commit 3c5fec75e121b21a2eb35e5a6b44291509abba6f upstream.
>     
>     Restoring the missing INDEX register value in musb_restore_context().
>     Without this suspend resume functionality is broken with offmode
>     enabled.
>     
>     Acked-by: Anand Gadiyar <gadiyar@xxxxxx>
>     Signed-off-by: Ajay Kumar Gupta <ajay.gupta@xxxxxx>
>     Signed-off-by: Felipe Balbi <balbi@xxxxxx>
>     Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> 
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index 24212be..b9afd6a 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -1634,6 +1634,7 @@ void musb_dma_completion(struct musb *musb, u8 epnum, u8 transmit)
>                         }
>                 }
>         }
> +       musb_writeb(musb_base, MUSB_INDEX, musb->context.index);
>  }
>  
>  #else
> """
> breaks the linux-2.6.32.y branch in linux-stable as there is no
> 'context' member in struct musb. I've not checked to see which other
> branches are broken.
> 
> I guess it's relatively fortunate that the whole patch is unwanted, as
> presumably it can be just reverted?

Thanks for letting me know, I've now reverted it.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux