Re: [PATCH] fix EHCI HUB TT scheduling issue with iso transfert

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 27 Oct 2011, Thomas Poussevin wrote:

> The current TT scheduling doesn't allow to play and then record on a 
> full-speed
> device connected to a high speed hub.
> 
> The IN iso stream can only start on the first uframe (0-2 for a 165 us) 
> because
> of CSPLIT transactions.
> For the OUT iso stream there no such restriction. uframe 0-5 are possible.
> 
> The idea of this patch is that the first uframe are precious (for IN TT iso
> stream) and we should allocate the last uframes first if possible.
> 
> For that we reverse the order of uframe allocation (last uframe first).

You didn't add a comment in the code explaining why the loop goes 
backwards.  Just mention that early uframes are more precious because 
full-speed iso IN transfers can't use late uframes, and therefore they 
should be allocated last.

Also, there's a spelling error in the patch title ("transfert" may be a 
good word in German, but not in English).

Finally, when you submit the patch send it to Greg KH as well as to me, 
and put the patch directly in the email message instead of attaching 
it, using the format specified in Documentation/SubmittingPatches.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux