Re: [PATCH] USB: workaround for bug in old version of GCC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 27, 2011 at 11:20:21AM -0400, Alan Stern wrote:
> This patch (as1491) works around a bug in GCC-3.4.6, which is still
> supposed to be supported.  The number of microseconds in the udelay()
> call in quirk_usb_disable_ehci() is fixed at 100, but the compiler
> doesn't understand this and generates a link-time error.  So we
> replace the otherwise unused variable "delta" with a simple constant
> 100.  This same pattern is already used in other delay loops in that
> source file.
> 
> Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Reported-by: Konrad Rzepecki <krzepecki@xxxxxxxxxxx>
> CC: <stable@xxxxxxxxxx>
> 
> ---
> 
> On Thu, 27 Oct 2011, Greg KH wrote:
> 
> > Good point.  Try what Alan suggested and post this on the linux-kernel
> > mailing list, it's not a USB specific issue that we can help you out
> > with here, sorry.
> 
> It's really not a very big issue.  This patch will fix the problem; I 
> don't see any reason not to merge it.

Ok, thanks, I didn't realize it would be so simple.  I'll queue this up
to send to Linus after 3.2-rc1 is out.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux