On Sun, Oct 23, 2011 at 2:00 AM, Olof Johansson <olof@xxxxxxxxx> wrote: > > Hi, > > On Fri, Oct 21, 2011 at 10:33 AM, Olof Johansson <olof@xxxxxxxxx> wrote: > > On Fri, Oct 14, 2011 at 03:08:34PM -0700, tmarri@xxxxxxx wrote: > >> From: Tirumala Marri <tmarri@xxxxxxx> > > > > Overall this driver seems to be based on the IP vendor driver? It > > looks like a completely flexible driver that implements all possible > > combinations of everything. > > After looking a little closer at the patch set, it seems that number > one thing you need to do is simplify the driver. A lot. > > I suggest starting from scratch with a clean implementation, only > bringing in the pieces you need. Over time, if other vendors are using Writing from scratch might take lot of time. I have used this driver on a ARM based platform, and found it stable after just a bit modification , which I have suggested in my earlier mails. I have run all the test cases of standard testusb (except for iscochronous), and have found them working after the suggested modifications. So, I think that driver is stable in a sense, and can be included into mainline. Regards Pratyush > other aspects of the same IP, they get to add those parts of the > driver when they need it. Look at the dwc3 driver for comparison on > cleanliness, it's much cleaner than what you've posted. > > > -Olof > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
