Hi Felipe, Paul
> > From: Felipe Balbi <balbi <at> ti.com>
> >
> > | drivers/usb/renesas_usbhs/fifo.c: In function ‘usbhsf_dma_prepare_push’:
> > | drivers/usb/renesas_usbhs/fifo.c:823:7: warning: cast from pointer \
> > to integer of different size [-Wpointer-to-int-cast]
> > | drivers/usb/renesas_usbhs/fifo.c: In function ‘usbhsf_dma_try_pop’:
> > | drivers/usb/renesas_usbhs/fifo.c:900:7: warning: cast from pointer \
> > to integer of different size [-Wpointer-to-int-cast]
> >
> > Signed-off-by: Felipe Balbi <balbi <at> ti.com>
(snip)
> > @@ -897,7 +897,7 @@ static int usbhsf_dma_try_pop(struct usbhs_pkt *pkt, int *is_done)
> > if (!fifo)
> > goto usbhsf_pio_prepare_pop;
> >
> > - if (((u32)pkt->buf + pkt->actual) & 0x7) /* 8byte alignment */
> > + if ((*(u32 *) pkt->buf + pkt->actual) & 0x7) /* 8byte alignment */
> > goto usbhsf_pio_prepare_pop;
> >
> > ret = usbhsf_fifo_select(pipe, fifo, 0);
>
> As pointed out by Sergei, this is pretty obviously a bogus conversion. I
> think this one should be reverted.
I guess above warning came from 64bit compiler ?
My environment is still 32bit, so I didn't noticed this cast issue.
But is below patch solve this warning/bug ?
(I'm not good at 64bit)
------------------------------
diff --git a/drivers/usb/renesas_usbhs/fifo.c b/drivers/usb/renesas_usbhs/fifo.c
index 762b742..6927b8f 100644
--- a/drivers/usb/renesas_usbhs/fifo.c
+++ b/drivers/usb/renesas_usbhs/fifo.c
@@ -820,7 +820,7 @@ static int usbhsf_dma_prepare_push(struct usbhs_pkt *pkt, in
if (len % 4) /* 32bit alignment */
goto usbhsf_pio_prepare_push;
- if ((*(u32 *) pkt->buf + pkt->actual) & 0x7) /* 8byte alignment */
+ if ((uintptr_t)(pkt->buf + pkt->actual) & 0x7) /* 8byte alignment */
goto usbhsf_pio_prepare_push;
/* get enable DMA fifo */
@@ -897,7 +897,7 @@ static int usbhsf_dma_try_pop(struct usbhs_pkt *pkt, int *is
if (!fifo)
goto usbhsf_pio_prepare_pop;
- if ((*(u32 *) pkt->buf + pkt->actual) & 0x7) /* 8byte alignment */
+ if ((uintptr_t)(pkt->buf + pkt->actual) & 0x7) /* 8byte alignment */
goto usbhsf_pio_prepare_pop;
ret = usbhsf_fifo_select(pipe, fifo, 0);
------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
