On Mon, 2011-10-24 at 10:33 +0800, zheng.zhijian@xxxxxxxxxx wrote: > this patch adds ZTE modem devices Are the USB interfaces of any of these devices network ports or other ports that shouldn't be used via serial drivers? These days a number of ZTE devices are showing up where one of the USB interfaces is actually a network port, and that port shouldn't be driven by 'option'. Examples of these modems are the ZTE K3765Z, MF626, and others, and we get this information from the Windows driver .INF files. There's a blacklisting feature to the option driver that allows us to ensure that specific USB interfaces are ignored by option and available to other drivers instead. So do any of these devices need to have specific network or other interfaces blacklisted? And are any of these interfaces QCDM/DIAG interfaces? These may sometimes need to have special treatment as well (the SENDSETUP quirk) when the firmware doesn't reply to the setup commands on that interface, because DIAG interfaces usually use a very specific serial communication setup. Dan > --- > > --- a/drivers/usb/serial/option.c > +++ b/drivers/usb/serial/option.c > @@ -316,6 +316,9 @@ static void option_instat_callback(struct urb *urb); > #define ZTE_PRODUCT_AC8710 0xfff1 > #define ZTE_PRODUCT_AC2726 0xfff5 > #define ZTE_PRODUCT_AC8710T 0xffff > +#define ZTE_PRODUCT_MC2718 0xffe8 > +#define ZTE_PRODUCT_MG3732 0xffeb > +#define ZTE_PRODUCT_MC2716 0xffed > > #define BENQ_VENDOR_ID 0x04a5 > #define BENQ_PRODUCT_H10 0x4068 > @@ -1003,6 +1006,22 @@ static const struct usb_device_id option_ids[] = { > { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, ZTE_PRODUCT_AC8710, > 0xff, 0xff, 0xff) }, > { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, ZTE_PRODUCT_AC2726, > 0xff, 0xff, 0xff) }, > { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, > ZTE_PRODUCT_AC8710T, 0xff, 0xff, 0xff) }, > + { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, ZTE_PRODUCT_MC2718, > 0xff, 0xff, 0xff) }, > + { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, ZTE_PRODUCT_MG3732, > 0xff, 0xff, 0xff) }, > + { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, ZTE_PRODUCT_MC2716, > 0xff, 0xff, 0xff) }, > + { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0xfffd, 0xff, 0xff, > 0xff) }, > + { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0xfffc, 0xff, 0xff, > 0xff) }, > + { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0xfffb, 0xff, 0xff, > 0xff) }, > + { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0xfff6, 0xff, 0xff, > 0xff) }, > + { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0xfff7, 0xff, 0xff, > 0xff) }, > + { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0xfff8, 0xff, 0xff, > 0xff) }, > + { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0xfff9, 0xff, 0xff, > 0xff) }, > + { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0xffdd, 0xff, 0xff, > 0xff) }, > + { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0xffef, 0xff, 0xff, > 0xff) }, > + { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0xffee, 0xff, 0xff, > 0xff) }, > + { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0xffec, 0xff, 0xff, > 0xff) }, > + { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0xffea, 0xff, 0xff, > 0xff) }, > + { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0xffe9, 0xff, 0xff, > 0xff) }, > { USB_DEVICE(BENQ_VENDOR_ID, BENQ_PRODUCT_H10) }, > { USB_DEVICE(DLINK_VENDOR_ID, DLINK_PRODUCT_DWM_652) }, > { USB_DEVICE(ALINK_VENDOR_ID, DLINK_PRODUCT_DWM_652_U5) }, /* Yes, > ALINK_VENDOR_ID */ > > --- > Signed-off-by: wsalvin <wsalvin@xxxxxxxxxxxx> > Signed-off-by: Alvin.Zheng <zheng.zhijian@xxxxxxxxxx> > > > -------------------------------------------------------- > ZTE Information Security Notice: The information contained in this mail is solely property of the sender's organization. This mail communication is confidential. Recipients named above are obligated to maintain secrecy and are not permitted to disclose the contents of this communication to others. > This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the originator of the message. Any views expressed in this message are those of the individual sender. > This message has been scanned for viruses and Spam by ZTE Anti-Spam system. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html