Re: [RFC/PATCH] usb: dwc3: gadget: implement streams support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 19, 2011 at 06:20:53PM +0200, Sebastian Andrzej Siewior wrote:
> On 09/29/2011 01:02 PM, Felipe Balbi wrote:
> 
> >diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> >index c9b011a..8270671 100644
> >--- a/drivers/usb/dwc3/gadget.c
> >+++ b/drivers/usb/dwc3/gadget.c
> >@@ -264,6 +264,12 @@ static int dwc3_gadget_set_ep_config(struct dwc3 *dwc, struct dwc3_ep *dep,
> >  	params.param1.depcfg.xfer_complete_enable = true;
> >  	params.param1.depcfg.xfer_not_ready_enable = true;
> >
> >+	if (usb_endpoint_xfer_bulk(desc)&&  dep->endpoint.max_streams) {
> Should we test for SS speed as well?

struct usb_ep.max_streams should only be set on SuperSpeed endpoints.

> >+		params.param1.depcfg.stream_capable = true;
> >+		params.param1.depcfg.stream_event_enable = true;
> this is just used to enable some debug output. Could we put an ifdef
> debug around it?

Currenlty we're only using for debugging output. After we see streams
working, we might decide to use it in a different way.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux