Re: [PATCH 23/68] usb: gadget: renesas_usbhs: each pipe hold maxpacket size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 14, 2011 at 04:41:40PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 13-10-2011 21:56, Felipe Balbi wrote:
> 
> >From: Kuninori Morimoto<kuninori.morimoto.gx@xxxxxxxxxxx>
> 
> >Current renesas_usbhs pipe accessed DCPMAXP/PIPEMAXP register
> >to get own maxpacket size every time.
> >But maxpacket size isn't changed after pipe start,
> >and register access is too slow.
> 
> >This patch adds new maxp variable to keep own maxpacket.
> >And un-used function are removed.
> 
> >Signed-off-by: Kuninori Morimoto<kuninori.morimoto.gx@xxxxxxxxxxx>
> >Signed-off-by: Felipe Balbi<balbi@xxxxxx>
> >---
> >  drivers/usb/renesas_usbhs/pipe.c |   29 ++++++++---------------------
> >  drivers/usb/renesas_usbhs/pipe.h |    2 ++
> >  2 files changed, 10 insertions(+), 21 deletions(-)
> 
> >diff --git a/drivers/usb/renesas_usbhs/pipe.c b/drivers/usb/renesas_usbhs/pipe.c
> >index 1af1905..1f86bed 100644
> >--- a/drivers/usb/renesas_usbhs/pipe.c
> >+++ b/drivers/usb/renesas_usbhs/pipe.c
> [...]
> >@@ -477,11 +463,12 @@ void usbhs_pipe_config_update(struct usbhs_pipe *pipe, u16 epnum, u16 maxp)
> >   */
> >  int usbhs_pipe_get_maxpacket(struct usbhs_pipe *pipe)
> 
>    I'd have marked this function *inline* (if not eliminated it altogether).

compiler will definitely do that.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux