Re: [PATCH] usb: gadget: storage: check for valid USB_BULK_GET_MAX_LUN_REQUEST

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi again,

On Fri, Oct 14, 2011 at 09:56:42AM +0300, Felipe Balbi wrote:
> On Thu, Oct 13, 2011 at 09:42:40PM -0400, Alan Stern wrote:
> > On Thu, 13 Oct 2011, Paul Zimmerman wrote:
> > 
> > > The latest USB-IF CV tester checks for a valid length for this
> > > request.
> > 
> > That's dumb.  The BOT spec doesn't say anything about what a device
> > should do if it receives a request with wLength > 1.  Therefore it's
> > wrong to say that a device is non-compliant with the spec if it replies
> > to such requests.
> > 
> > If anything, this should be a test of the host, not of the device.  
> > After all, it's the host's fault if wLength is set to the wrong value.
> > 
> > Instead of changing this, I'd prefer to complain to the USB-IF.
> 
> It's the same with SetAddress command. A SetAddress() on Configured
> state has unspecified answer, nevertheless USB-IF is very, very bad at
> changing those Command Verifier tools and every time I have tried
> reporting a bug (either on Windows Stack or Command Verifier Stack) they
> always reply with the same stock answer: "Other devices have passed
> certification on the same setup, so why can't you?"
> 
> That means the USB Certified sticker has nothing to do with being
> compliant with the Spec, rather being compliant with Windows.
> 
> On top of all that, if we don't apply this there will be a big number of
> Linux devices which will have to keep this patch on their own out of
> tree queue just to pass certification.
> 
> Do we want that ? I think it's far better to apply this patch, but mark
> it as host-side quirk or something. The host stack has quirks for
> out-of-spec devices, why can't the device stack have quirk for
> out-of-spec hosts ?

I just sent a query to USB-IF regarding SetAddress command. I didn't add
this one to the email because I didn't find it and didn't read the specs
to be sure how to phrase the mail.

For anyone willing to go through a talk with USB-IF, the email for
USB30CV complaints is ssusbcompliance@xxxxxxx

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux