Hi, On Thu, Oct 13, 2011 at 09:19:48AM +0300, Felipe Balbi wrote: > On Wed, Oct 12, 2011 at 06:38:07PM -0700, Paul Zimmerman wrote: > > Felipe Balbi <balbi () ti ! com> writes: > > > > > our parameter structures need to be written to > > > HW, so instead of assuming little endian, we > > > convert those into bit shifts. > > > > > > Signed-off-by: Felipe Balbi <balbi () ti ! com> > > > > Hi Felipe, > > > > It seems this patch is not complete. You are also using bitfields for the > > TRBs and events. Any plans to fix those? > > Will change those in a later patch unless someone else beats me to it. > I'm currently working on using GHWPARAMS* to make the driver a bit more > flexible. OTOH, Sebastian had already taken care of endianness by using that struct dwc3_trb and struct dwc3_trb_hw trick. Let's wait for his comment. Sebastian ? (I guess he's still on vacations) -- balbi
Attachment:
signature.asc
Description: Digital signature