On 8 September 2010 10:34, Greg KH <gregkh@xxxxxxx> wrote: > > On Wed, Sep 08, 2010 at 02:54:02AM +0300, Mihai Don??u wrote: > > On Wednesday 08 September 2010 00:29:15 Greg KH wrote: > > > On Tue, Sep 07, 2010 at 04:18:23PM +0530, Gadiyar, Anand wrote: > > > > Since Greg has already sent a pull request, I won't touch the file > > > > now; maybe a trivial patch later on to fix up the coding style. > > > > > > That would be fine to have, I'd gladly accept it. > > > > Would something like the following do? It's against: > > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb-2.6.git > > > > Corrected the coding style. > > Looks good, thanks, I'll go queue it up. Did this patch get applied and the problem resolved? I'm running 2.6.33.7-rt29 and we have a customer in India who complains that they can't connect via USB. We don't have the problem here, or anywhere else that we know of. I looked at the logs of the device and it appears to have the same Oops error as the one that this patch addresses. e.g. Oct 7 15:52:50 MDR4330-9000205 user.emerg kernel: Internal error: Oops: 17 [#1] PREEMPT Oct 7 15:52:50 MDR4330-9000205 user.emerg kernel: last sysfs file: /sys/devices/platform/reader/firmware/reader/loading Oct 7 15:52:50 MDR4330-9000205 user.warn kernel: Modules linked in: readerdrv g_ether vfat fat Oct 7 15:52:50 MDR4330-9000205 user.warn kernel: CPU: 0 Not tainted (2.6.33.7-rt29-magarm #101) Oct 7 15:52:50 MDR4330-9000205 user.warn kernel: PC is at strlen+0x10/0x34 Oct 7 15:52:50 MDR4330-9000205 user.warn kernel: LR is at rndis_msg_parser+0x81c/0x159c [g_ether] Oct 7 15:52:50 MDR4330-9000205 user.warn kernel: pc : [<c013f0d8>] lr : [<bf01cf30>] psr: 60000013 Aras -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html