On Mon, 10 Oct 2011, Felipe Balbi wrote:
> Hi,
>
> On Mon, Oct 10, 2011 at 07:07:17PM +0300, Felipe Balbi wrote:
> > On Mon, Oct 10, 2011 at 11:10:22AM -0400, Alan Stern wrote:
> > > On Mon, 10 Oct 2011, Felipe Balbi wrote:
> > >
> > > > this patch adds superspeed descriptors for the
> > > > storage gadgets.
> > >
> > > This looks quite good. There's one thing I'm not sure about:
> > >
> > > > --- a/drivers/usb/gadget/file_storage.c
> > > > +++ b/drivers/usb/gadget/file_storage.c
> > > > @@ -586,7 +586,22 @@ dev_qualifier = {
> > > > .bNumConfigurations = 1,
> > > > };
> > > >
> > > > +static int populate_bos(struct fsg_dev *fsg, u8 *buf)
> > > > +{
> > > > + fsg_bos_desc.wTotalLength = USB_DT_BOS_SIZE
> > > > + + USB_DT_USB_SS_CAP_SIZE + USB_DT_USB_EXT_CAP_SIZE;
> > >
> > > Is there any particular reason this field is computed dynamically?
> > > Does it need to be different for the various drivers?
> >
> > not really, no. I can move it back to static initialization.
>
> here's v2 of $SUBJECT:
>
> From 14a606c340dafec9549bc40039c8b9843976e48a Mon Sep 17 00:00:00 2001
> From: Felipe Balbi <balbi@xxxxxx>
> Date: Wed, 3 Aug 2011 14:33:27 +0300
> Subject: [PATCH v2] usb: gadget: storage: add superspeed support
>
> this patch adds superspeed descriptors for the
> storage gadgets.
>
> Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> ---
>
> Changes from v1:
> - statically initialy wTotalLength on BOS desc.
For the file-storage and storage_common parts:
Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
