Re: [PATCH 30/30] USB: ftdi_sio: add Calao reference board support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 05, 2011 at 11:31:33AM +0200, Uwe Bonnes wrote:
> >>>>> "Greg" == Greg Kroah-Hartman <gregkh@xxxxxxx> writes:
> 
>     Greg> From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx>
>     Greg> Calao use on there dev kits a FT2232 where the port 0 is used for
>     Greg> the JTAG and port 1 for the UART
> 
>     Greg> They use the same VID and PID as FTDI Chip but they program the
>     Greg> manufacturer name in the eeprom
> 
>     Greg> So use this information to detect it
> 
> Sorry, but I feel that this special handling is kernel bloat. I have lot's
> of boards where the FT2232 has dual purpose and as I don't own a FTDI PID,
> all distinction is done by the strings I program into the FTDI I2C
> EEPROM. When plugging the device, the kernel creates a ttyUSB device, but as
> soon as my libusb application grabs the device, libusb detaches the ttyUSB.
> 
> Why a special handling for some special device that can be done in user
> space?

How can this be done in userspace?

> I would propose to drop ftdi_jtag_probe(), ftdi_8u2232c_probe() and 
> ftdi_stmclite_probe().

Just remove it?  Care to provide a patch, with the reasoning why this
should be applied in the changelog comment and we can review it there?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux