Hi, On Thu, Sep 29, 2011 at 02:50:21PM -0700, Paul Zimmerman wrote: > > From: Felipe Balbi [mailto:balbi@xxxxxx] > > Sent: Thursday, September 29, 2011 2:44 PM > > > > On Thu, Sep 29, 2011 at 01:36:49PM -0700, Paul Zimmerman wrote: > > < snip > > > > > As I understand it, using bitfields to access hardware is frowned upon > > > in the Linux kernel, instead you should use shift-and-mask. Do you plan > > > to fix this? > > > > You are correct :-) I will fix this all tomorrow. Should be fairly > > simple, though long, patch. > > > > Do you have a big endian system to test against ? > > Unfortunately, no. But if you get rid of all the bitfields it should be > correct by-design :) heh, I agree with you here. I have a preliminary patch which I'll test tomorrow just to be sure I didn't mess up anything. Gotta sleep now, quite late. ttyl -- balbi
Attachment:
signature.asc
Description: Digital signature
