Hi,
On Wed, Sep 28, 2011 at 02:27:10PM +0200, Daniel Mack wrote:
> On Wed, Sep 28, 2011 at 2:22 PM, Felipe Balbi <balbi@xxxxxx> wrote:
> > On Tue, Sep 20, 2011 at 06:59:27PM +0200, Daniel Mack wrote:
> >> Make use of the newly added MIDI function in f_midi.c and strip down
> >> the MIDI gadget code radically. Also use the generic framework function
> >> to avoid code duplication and rename some symbols to bring them in sync
> >> with other code in the gadget framework.
> >>
> >> Signed-off-by: Daniel Mack <zonque@xxxxxxxxx>
> >> Cc: Felipe Balbi <balbi@xxxxxx>
> >> Cc: Greg Kroah-Hartman <gregkh@xxxxxxx>
> >> Cc: Ben Williamson <ben.williamson@xxxxxxxxxxxxxxxxxx>
> >> ---
> >> drivers/usb/gadget/midi.c | 1286 +++------------------------------------------
> >> 1 files changed, 80 insertions(+), 1206 deletions(-)
> >>
> >> diff --git a/drivers/usb/gadget/midi.c b/drivers/usb/gadget/midi.c
> >> index 8b9220e..b3d93ac 100644
> >> --- a/drivers/usb/gadget/midi.c
> >> +++ b/drivers/usb/gadget/midi.c
> >> @@ -36,134 +36,35 @@
> >>
> >> #include "gadget_chips.h"
> >>
> >> -
> >> -/*
> >> - * Kbuild is not very cooperative with respect to linking separately
> >> - * compiled library objects into one module. So for now we won't use
> >> - * separate compilation ... ensuring init/exit sections work to shrink
> >> - * the runtime footprint, and giving us at least some parts of what
> >> - * a "gcc --combine ... part1.c part2.c part3.c ... " build would.
> >> - */
> >> +#include "composite.c"
> >> #include "usbstring.c"
> >> #include "config.c"
> >> #include "epautoconf.c"
> >> +#include "f_midi.c"
> >>
> >> /*-------------------------------------------------------------------------*/
> >>
> >> -
> >> -MODULE_AUTHOR("Ben Williamson");
> >> +MODULE_AUTHOR("Ben Williamson, Daniel Mack");
> >
> > two entries. BTW, if your just moving code around, how can you be the
> > author ?? Similarly to previous patch.
>
> Well, I moved core parts around, but changed everything else to make
> it fit the composite framework. Eventually (after all 4 patches are
> applied), much of the code is actually rewritten But I don't insist in
> authorship here at all. I can just remove that if you like.
The fact is that the original code was written by someone else, so he's
the original author. Maybe adding an extra one would be ok, if you're
willing to spend time improving this even further should any bug reports
pop up.
Greg, do you have any rule of thumb for Module Authorship ??
--
balbi
Attachment:
signature.asc
Description: Digital signature
