Re: [PATCH 0/3] Support for MIDI gadget functions in composite devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Any oppinion about these patches?

Thanks,
Daniel


On Tue, Sep 20, 2011 at 7:01 PM, Daniel Mack <zonque@xxxxxxxxx> wrote:
> Ben's email address bounces. Make sure to remove it from the list when replying.
>
> Daniel
>
>
> On Tue, Sep 20, 2011 at 6:59 PM, Daniel Mack <zonque@xxxxxxxxx> wrote:
>> Here is a series of 3 patches that add support for MIDI functions in
>> composite devices.
>>
>> The first one simply renames gmidi.c to midi.c to clean up the file
>> name space a bit.
>>
>> The second adds f_midi.c which implements a rewritten version of the
>> MIDI gadget code, suitable for composite device inclusion.
>>
>> The third one removes duplicate code and reuses f_midi.c from midi.c.
>>
>> I tested this with both the MIDI standalone function as well as with
>> a HID/MIDI combined config and it seems to work fine.
>>
>> Any comments welcome :)
>>
>>
>> Thanks,
>> Daniel
>>
>>
>> Daniel Mack (3):
>>  USB: gadget: rename g_midi.c to midi.c
>>  USB: gadget: added midi function driver for the composite framework
>>  USB: gadget: refactor the MIDI device code
>>
>>  drivers/usb/gadget/Makefile |    2 +-
>>  drivers/usb/gadget/f_midi.c |  918 ++++++++++++++++++++++++++++++
>>  drivers/usb/gadget/gmidi.c  | 1321 -------------------------------------------
>>  drivers/usb/gadget/midi.c   |  195 +++++++
>>  4 files changed, 1114 insertions(+), 1322 deletions(-)
>>  create mode 100644 drivers/usb/gadget/f_midi.c
>>  delete mode 100644 drivers/usb/gadget/gmidi.c
>>  create mode 100644 drivers/usb/gadget/midi.c
>>
>> --
>> 1.7.6
>>
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux