On Fri, 23 Sep 2011, Serge E. Hallyn wrote: > > > > This should be broken up into two separate patches: One to add > > > > kill_pid_info_as_cred() and the other to modify the usbfs driver. > > > > > > It seems like that would make the first patch harder to review (since > > > it won't just show the changes from kill_pid_info_as_uid to > > > kill_pid_info_as_cred), but I'll go ahead and split it up. I assume > > > kill_pid_info_as_uid should be removed in a third patch? > > > > No, what I meant was that all the changes to /kernel/signal.c should be > > in one patch and all the changes to drivers/usb/core/devio.c should be > > in a second patch. > > But doing that in two patches would not be bisect-safe. Argh, you're right. It's not a good idea to combine changes to widely differing subsystems in a single patch, but luckily this is small enough that it doesn't matter too much. If nobody else minds, I won't complain. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
