On 09/21/2011 08:27 AM, Neil Zhang wrote:
Hi Sebastian,
Hi Neil,
udc->phy_regs = (unsigned int)ioremap(r->start, resource_size(r));
No, ioremal returns __iomem and a pointer. Casting to int is wrong.
Keep
the pointer please.
Thanks for find out this issue, I will cast it to unsigned long here, and
platform related driver need to cast back to void __iomem * before readl/writel.
Please just make sure that udc->phy_regs are of the same type as
returned by ioremap() and you don't need any castings. Not here, not
while using readl/writel or any other access function.
diff --git a/drivers/usb/gadget/mv_udc_phy.c
b/drivers/usb/gadget/mv_udc_phy.c
deleted file mode 100644
index d4dea97..0000000
--- a/drivers/usb/gadget/mv_udc_phy.c
+++ /dev/null
Not sure it is a good idea to hide the phys in arch/arm instead of here.
We have some different SOC use this USB IP and the PHY setting are different.
So it maybe a reasonable choice to realize it in platform relative driver.
Yeah, I assumed that. The thing is that people are trying to come up
with a phy layer. Please try to switch over to this once it is merged :)
Sebastian
Best Regards,
Neil Zhang
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
