Re: [PATCH 3.1] xhci-mem.c: Check for ring->first_seg != NULL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 19, 2011 at 04:53:12PM -0700, Sarah Sharp wrote:
> From: Kautuk Consul <consul.kautuk@xxxxxxxxx>
> 
> There are 2 situations wherein the xhci_ring* might not get freed:
> - When xhci_ring_alloc() -> xhci_segment_alloc() returns NULL and
>   we goto the fail: label in xhci_ring_alloc. In this case, the ring
>   will not get kfreed.
> - When the num_segs argument to xhci_ring_alloc is passed as 0 and
>   we try to free the rung after that.
>   ( This doesn't really happen as of now in the code but we seem to
>     be entertaining num_segs=0 in xhci_ring_alloc )
> 
> This should be backported to kernels as old as 2.6.31.
> 
> Signed-off-by: Kautuk Consul <consul.kautuk@xxxxxxxxx>
> Signed-off-by: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxx
> ---
> 
> Hi Greg,
> 
> Here's one more bug fix for 3.1.  If it's too late for 3.1, you can just
> apply it to the 3.2 branch.

Ok, I'll queue it up there, that's easier at the moment.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux