Hi all, Greg,
I added support for the Sierra Wireless MC8355, but my "problem" is
that there are several (tiny) patches which work. I am at a loss
deciding which way is best so I'd like to get your input.
There are three ways that work, namely:
1) forcing module loading
modprobe usbserial vendor=0x1199 product=0x9013
2)
richih@rockhopper ~git/linux % git diff
02f8c6aee8df3cdc935e9bdd4f2d020306035dbe..14fd2fc8cfc198c4a99433f11b8c85e0292de551
diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
index d5d136a..1d26b76 100644
--- a/drivers/usb/serial/sierra.c
+++ b/drivers/usb/serial/sierra.c
@@ -301,6 +301,7 @@ static const struct usb_device_id id_table[] = {
{ USB_DEVICE(0x1199, 0x68A3), /* Sierra Wireless Direct IP modems */
.driver_info = (kernel_ulong_t)&direct_ip_interface_blacklist
},
+ { USB_DEVICE(0x1199, 0x9013) }, /* Sierra Wireless MC8355 */
{ USB_DEVICE(0x0f3d, 0x68A3), /* Airprime/Sierra Wireless
Direct IP modems */
.driver_info = (kernel_ulong_t)&direct_ip_interface_blacklist
},
3)
richih@rockhopper ~git/linux % git diff
02f8c6aee8df3cdc935e9bdd4f2d020306035dbe..b9915956b3ca44efe8658197d1ae07c2fe5f7656
diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
index 54a9dab..fd68a16 100644
--- a/drivers/usb/serial/qcserial.c
+++ b/drivers/usb/serial/qcserial.c
@@ -82,6 +82,7 @@ static const struct usb_device_id id_table[] = {
{USB_DEVICE(0x16d8, 0x8002)}, /* CMDTech Gobi 2000 Modem
device (VU922) */
{USB_DEVICE(0x05c6, 0x9204)}, /* Gobi 2000 QDL device */
{USB_DEVICE(0x05c6, 0x9205)}, /* Gobi 2000 Modem device */
+ {USB_DEVICE(0x1199, 0x9013)}, /* Sierra Wireless Gobi 3000
Modem device (MC8355) */
{ } /* Terminating entry */
};
MODULE_DEVICE_TABLE(usb, id_table);
richih@rockhopper ~git/linux %
UMTS, Edge, GPRS & GPS work well with all of those. No idea about CDMA
as I can't test that.
I would tend to choose 2) as it's Sierra's USB vendor ID. OTOH,
qcserial has several SW definitions.
Once I submit the patch properly, is "[USB] Added support for Sierra
Wireless MC8355" a good title?
Thanks,
Richard
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
