Re: [PATCH 1/3] ehci: Support for Intel Moorestown MPH and OTG host

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> I'm a little confused about the point of this.  Why is a special
> registration for the USB host controller driver needed?  Is it somehow
> too drastically different from a normal PCI driver?

I'm not sure I follow - you can't bind two drivers at once to one PCI
device or vice versa.

> 
> > --- a/include/linux/usb/hcd.h
> > +++ b/include/linux/usb/hcd.h
> > @@ -174,6 +174,12 @@ struct usb_hcd {
> >  	 * (ohci 32, uhci 1024, ehci 256/512/1024).
> >  	 */
> >  
> > +	/* some otg HCDs need this to get USB_DEVICE_ADD and USB_DEVICE_REMOVE
> > +	 * from root hub, we do not want to use USB notification chain, since
> > +	 * it would be a over kill to use high level notification.
> > +	 */
> > +	void (*otg_notify) (struct usb_device *udev, unsigned action);
> 
> Why is it overkill to use the high-level notification mechanism?  It's 
> already there and its notifications are going to be sent out 
> regardless.  This is exactly the sort of thing it was meant for.

Ok thats the feedback I need to. I will investigate taking an axe to
all that stuff and try and chop it into something under control

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux