Re: [PATCH] usbcore: refine warm reset logic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 26, 2011 at 11:13:08AM -0400, Alan Stern wrote:
> On Thu, 25 Aug 2011, Sarah Sharp wrote:
> 
> > Note that the mask does not include the warm port reset bit (PORT_WRC).
> > When I applied the attached patch to include the warm port reset bit
> > change in the mask on top of Andiry's patch (plus the modifications I
> > made), the USB core did clear the BH reset change.
> 
> Your patch includes a FIXME asking about the PORT_RC field.  The answer
> is that reset-change does not need to be reported (indeed, UHCI doesn't
> support it at all) unless it causes an IRQ, in which case you have to
> report it so that usbcore can turn off the IRQ source.  We don't use it
> for anything because it never gets set spontaneously -- it only gets
> set in response to a reset initiated by the host.

Ah, ok, I was too tired after debugging yesterday to remove the FIXME
note before sending it. :)

Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux