> -----Original Message----- > From: Sarah Sharp [mailto:sarah.a.sharp@xxxxxxxxxxxxxxx] > Sent: Wednesday, August 10, 2011 12:19 AM > To: Xu, Andiry > Cc: linux-usb@xxxxxxxxxxxxxxx; gregkh@xxxxxxx; > stern@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 6/8] xHCI: calculate HIRD > > > > > I'm converting it to HIRD(BESL), which will only be used by USB2 LPM. > > Driver can always retrieve the host controller exit latency at any > time, > > like this: > > > > + xhci->u2del = HCS_U2_LATENCY(xhci->hcs_params3); > > True. However, if you're not planning on sharing that value across > multiple code paths, and you're not accessing it very often in a > performance critical path, then why do you need to store it as a > parameter in xhci_hcd? That structure is getting awfully large. > It's a host controller attribute, and HIRD/BESL needs to be set for every LPM device test, so I guess it's better to calculate and store it once than calculate it in every software lpm test. Thanks, Andiry -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
