On Tue, Aug 09, 2011 at 10:53:17AM +1000, Matt Evans wrote: > Hi Greg, > > On 09/08/11 05:37, Greg KH wrote: > > On Mon, Aug 01, 2011 at 11:24:35AM +1000, Matt Evans wrote: > >> Hi Sebastian, > >> > >> On 29/07/11 19:05, Sebastian Andrzej Siewior wrote: > >>> wMaxPacketSize is __le16 and should be accessed as such. Also fix the > >>> wBytesPerInterval assignment while here. > >>> > >>> v2: also fix the wBytesPerInterval assigment, noticed by Matt Evans > >>> > >>> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> > >>> --- > >>> * Matt Evans | 2011-07-27 15:22:06 [+1000]: > >>> > >>>> Good find, actually I hadn't seen that. About 10 lines down there's a bad use > >>>> of wBytesPerInterval (which is now correctly typed thanks to your April patch) > >>>> but not written as LE: > >>>> > >>>> CHECK /home/matt/external-proj/usb-2.6/drivers/usb/core/config.c > >>>> ... > >>>> usb/drivers/usb/core/config.c:140:36: warning: incorrect type in assignment (different base types) > >>>> usb/drivers/usb/core/config.c:140:36: expected restricted __le16 [usertype] wBytesPerInterval > >>>> usb/drivers/usb/core/config.c:140:36: got int [signed] [assigned] max_tx > >>>> > >>>> Would you mind please fixing this while you're down there? > >>> > >>> Here it comes. For some reason my sparse does not say a word. > >> > >> Silly qu., but you're def. using C=2 CF="-D__CHECK_ENDIAN__" ? Seems odd if sparse > >> isn't seeing this. :-/ > > > > I don't seem to have the second version of this patch in my mboxes. > > Care to resend the updated version to me so that I can apply it? > > The V2 patch is in your usb-next branch (via Sarah on 2nd Aug) as > 7de7c7d2cb49900e0b967be871bf695c7d6135c9. (Or did you mean 'apply' in the > stable-tree context?) No, I'm confused, sorry, I didn't realize it came in through Sarah. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
