On Fri, Aug 5, 2011 at 6:01 PM, Felipe Balbi <balbi@xxxxxx> wrote:
> Hi,
>
> On Fri, Aug 05, 2011 at 05:35:17PM +0800, Bob Liu wrote:
>> On Fri, Aug 5, 2011 at 5:17 PM, Felipe Balbi <balbi@xxxxxx> wrote:
>> > On Fri, Aug 05, 2011 at 12:09:26PM +0800, Bob Liu wrote:
>> >> After the prefetch/list.h restructure, drivers need to explicitly include
>> >> linux/prefetch.h in order to use the prefetch() function. Otherwise, the
>> >> current driver fails to build:
>> >> drivers/usb/musb/blackfin.c: In function ???musb_write_fifo???:
>> >> drivers/usb/musb/blackfin.c:43: error: implicit declaration of function
>> >> ???prefetch???
>> >>
>> >> Signed-off-by: Bob Liu <lliubbo@xxxxxxxxx>
>> >
>> > would you have a commit to blame ?
>> >
>>
>> I think it was caused by commit e66eed651fd1 ("list: remove
>> prefetching from regular list
>> iterators").
>
> now that I look at it, you use prefetch directly without including
> <linux/prefetch.h> so the bug has always been on your driver :-)
>
Yes.
> similarly on tusb6010:
>
> $ git grep -e prefetch drivers/usb/musb/
> drivers/usb/musb/blackfin.c: prefetch((u8 *)src);
> drivers/usb/musb/musb_core.c:#include <linux/prefetch.h>
> drivers/usb/musb/musb_core.c: prefetch((u8 *)src);
> drivers/usb/musb/tusb6010.c: prefetch(buf);
>
> so here's a patch for tusb6010.c, I'll apply both to my fixes branch:
>
Thank you.
> diff --git a/drivers/usb/musb/tusb6010.c b/drivers/usb/musb/tusb6010.c
> index 9eec41f..ec14801 100644
> --- a/drivers/usb/musb/tusb6010.c
> +++ b/drivers/usb/musb/tusb6010.c
> @@ -18,6 +18,7 @@
> #include <linux/kernel.h>
> #include <linux/errno.h>
> #include <linux/init.h>
> +#include <linux/prefetch.h>
> #include <linux/usb.h>
> #include <linux/irq.h>
> #include <linux/platform_device.h>
>
> --
> balbi
>
--
Regards,
--Bob
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
