> -----Original Message----- > From: Sarah Sharp [mailto:sarah.a.sharp@xxxxxxxxxxxxxxx] > Sent: Friday, August 05, 2011 2:45 AM > To: Xu, Andiry > Cc: linux-usb@xxxxxxxxxxxxxxx > Subject: [RFC 0/3] xHCI bug fixes for URB enqueue and dequeue > > Hi Andiry, > > As I mentioned, I had been running into some issues with a prototype > host controller and several isochronous devices. I've tracked down the > bugs I was seeing to some issues in the URB enqueue and dequeue error > paths. > > I couldn't quite reproduce the failure I had last week, but I injected > some errors into the xHCI driver to make the stop endpoint command > watchdog timer fire, and to create a failure while enqueueing the > second > TD in a multi-TD isochronous URB. > > Since you wrote most of the isochronous code, could you review these > patches and make sure they look sane? If they do, I'll send them off > to > Greg, along with your other two bug fixes, tomorrow. > Thanks for fixing the issues I've made :) Basically they look OK but I've a couple of questions, see the comments in patch. Can you also evaluate the td allocation refine patch? It improves performance I think. Thanks, Andiry -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html