Hi,
On Thu, Aug 04, 2011 at 01:41:04AM +0300, Felipe Balbi wrote:
> Hi,
>
> On Wed, Aug 03, 2011 at 10:16:36AM -0400, Alan Stern wrote:
> > On Wed, 3 Aug 2011, Felipe Balbi wrote:
> >
> > > this patch adds superspeed descriptors for the
> > > storage gadgets.
> > >
> > > Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> >
> > ...
> >
> > > --- a/drivers/usb/gadget/storage_common.c
> > > +++ b/drivers/usb/gadget/storage_common.c
> > > @@ -493,12 +493,90 @@ static struct usb_descriptor_header *fsg_hs_function[] = {
> > > NULL,
> > > };
> > >
> > > +static struct usb_endpoint_descriptor
> > > +fsg_ss_bulk_in_desc = {
> > > + .bLength = USB_DT_ENDPOINT_SIZE,
> > > + .bDescriptorType = USB_DT_ENDPOINT,
> > > +
> > > + /* bEndpointAddress copied from fs_bulk_in_desc during fsg_bind() */
> > > + .bmAttributes = USB_ENDPOINT_XFER_BULK,
> > > + .wMaxPacketSize = cpu_to_le16(1024),
> > > +};
> > > +
> > > +static struct usb_ss_ep_comp_descriptor fsg_ss_bulk_in_comp_desc = {
> > > + .bLength = sizeof(fsg_ss_bulk_in_comp_desc),
> > > + .bDescriptorType = USB_DT_SS_ENDPOINT_COMP,
> >
> > Where does the bMaxBurst field get set up?
>
> well, it doesn't. It's not mandatory, right, to use Bursts here and,
> while it would be really nice to use it for command queueing, we don't
and here I confused bursts with streams ;-) sorry.
> know how windows will behave with a e.g. USB3-capable Bulk-only MSC
> device.
still optional, though, and we don't know how Windows would cope with
this. Does it make sense to add some value here ?
--
balbi
Attachment:
signature.asc
Description: Digital signature
