Re: [RFC PATCH 0/2] USB OTG rework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 01, 2011 at 05:35:46PM +0300, Felipe Balbi wrote:
> I would start by splitting <linux/usb/otg.h> into things which are
> really otg specific and things are only related to transceivers...

Well.. I though I did, with the new struct otg and struct
usb_transceiver. The phy utility does not have much, and can be part
of <linux/usb/otg.h> if you like.

> then I would rename struct otg_transceiver to struct usb_xceiv (yeah, I
> hate typing long names :-)

How about I call the usb_transceiver usb_xceiv. Just for you ;). We
can think about something like this but..

> only then I would start adding the PHY layer. Also, keep in mind that
> this will be a gigantic amount of work and all drivers in mainline need
> to be changed :-(

..This is why I decided it's better to keep the existing
otg_transceiver unchanged, so there will be plenty of time for all the
drivers to be ported to the new utility.

> I will review the two patches tomorrow... but here's my first 2 cents
> :-D

Let's see how you like them.

-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux