On Thu, Jul 28, 2011 at 8:41 PM, Felipe Balbi <balbi@xxxxxx> wrote: > On Thu, Jul 28, 2011 at 06:09:44PM +0300, Felipe Balbi wrote: >> Hi, >> >> On Thu, Jul 28, 2011 at 10:59:53PM +0800, tom.leiming@xxxxxxxxx wrote: >> > From: Ming Lei <tom.leiming@xxxxxxxxx> >> > >> > Obviously, disabling & put regulator and iounmap(hcd->regs) >> > are missed in .remove and failure handling path of .probe, >> > so add them. >> > >> > Signed-off-by: Ming Lei <tom.leiming@xxxxxxxxx> >> >> you didn't Cc Keshava again ;-) > > hmm, now that I checked, get_maintainer.pl won't add Keshava although > he's got a few commits on that driver: > > $ git log --author="Keshava" --pretty=oneline drivers/usb/host/ehci-omap.c > 6e3d4bec6b1e0829ed8b23be750762255f225019 omap:usb: add regulator support for EHCI > 19403165c272cc4ed00c97973e7271714b009708 usb: host: omap: ehci and ohci simplification > 181b250cf53233a7a7c6d7e1e9df402506712e93 arm: omap: usb: create common enums and structures for ehci and ohci > c072604115ab50d023eb5c33d4f3229400e441f4 usb: ehci-omap: don't hard-code TLL channel count > 6dba39e278b81665a838f37a75fe37b89f3ce610 usb: ehci-omap: update clock names to be more generic > > Anyway, nevermind. I already added him ;-) > > -- > balbi > sorry for the delay! It working on my omap3 sdp board Tested-by : Keshava Munegowda < keshava_mgowda@xxxxxx> regards keshava -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html