On Thu, Jul 21, 2011 at 10:24:10PM +0800, Shawn Guo wrote: > As cpu_is_mx stuff is being used in the driver, header mach/hardware.h > should be explicitly included. > > Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx> > --- > The missing of the header is causing today's linux-next build error > as bleow. > > CC drivers/usb/host/ehci-hcd.o > In file included from linux-next/drivers/usb/host/ehci-hcd.c:1190:0: > linux-next/drivers/usb/host/ehci-mxc.c: In function 'ehci_mxc_drv_probe': > linux-next/drivers/usb/host/ehci-mxc.c:175:2: error: implicit declaration of function 'cpu_is_mx35' > linux-next/drivers/usb/host/ehci-mxc.c:175:2: error: implicit declaration of function 'cpu_is_mx25' > linux-next/drivers/usb/host/ehci-mxc.c:185:2: error: implicit declaration of function 'cpu_is_mx51' I just hit this problem while build testing some of my patches. IMHO the build failure can go in the commit log, too. Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html