Re: [RFC/PATCH v2 03/11] usb: host: xhci: give xhci a platform_device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Felipe Balbi | 2011-07-27 01:23:02 [+0300]:

>it will make it simpler to re-use the stack
>if it's not tied to a particular bus. Later
>patches should come to phase PCI bus to a
>separate piece of code which doesn't touch
>xhci.c.
>
>Signed-off-by: Felipe Balbi <balbi@xxxxxx>
>---
> drivers/usb/host/xhci.c |  126 ++++++++++++++++++++++++++++++++++++++++++++++-
> 1 files changed, 125 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
>index f5fe1ac..d6c9577 100644
>--- a/drivers/usb/host/xhci.c
>+++ b/drivers/usb/host/xhci.c
>@@ -3058,7 +3180,8 @@ static int __init xhci_hcd_init(void)
> 	/* xhci_run_regs has eight fields and embeds 128 xhci_intr_regs */
> 	BUILD_BUG_ON(sizeof(struct xhci_run_regs) != (8+8*128)*32/8);
> 	BUILD_BUG_ON(sizeof(struct xhci_doorbell_array) != 256*32/8);
>-	return 0;
>+
>+	return platform_driver_register(&xhci_driver);
> }

You should unregister the PCI device if this failed.

> module_init(xhci_hcd_init);
> 

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux