> -----Original Message----- > From: Sarah Sharp [mailto:sarah.a.sharp@xxxxxxxxxxxxxxx] > Sent: Wednesday, July 27, 2011 2:47 AM > To: Xu, Andiry > Cc: linux-usb@xxxxxxxxxxxxxxx; gregkh@xxxxxxx > Subject: Re: [PATCH] xHCI: refine td allocation > > On Tue, Jul 26, 2011 at 08:34:11AM +0800, Andiry Xu wrote: > > In xhci_urb_enqueue(), allocate a block of memory for all the TDs > instead > > of allocating memory for each of them separately. This reduces the > number > > of kzalloc calling when an isochronous usb is submitted. > > Hi Andiry, > > I've actually been finding a lot of memory leaks and race conditions in > the isochronous transfer queueing. I have a box that consistently > hard-hangs with a certain setup of HS webcams and audio devices when > xHCI driver debugging is enabled. I'd like to root out those problems > before we do any optimizations. I'm at a conference this week, so I > won't be able to finish that bug fix until end of next week. Then we > can look and see if this patch is useful. Makes sense? > Yeah, please do so. It sounds like a time-related race issue. I have to admit that I've disabled xHCI driver dubugging for a quite long time. Do you mean xHCI hangs when webcam and audio devices are both plugged? Does it hang when isoc transfer is on-going? Can you give me the device names and I'll check if I can reproduce it locally. Thanks, Andiry -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
