> Although that said, since many of the USB properties are > board-specific > and determined by system characterization, they aren't generally > applicable to all Tegra devices. As such, should those values be moved > into tegra-seaboard.dts instead? Perhaps tegra20.dtsi should specify > the default values that the driver currently uses if not supplied with > platform data though... I think the Seaboard values are the defaults, > which still would make this patch obsolete. Turns out the ones I put in tegra20.dtsi are NOT the defaults. The defaults are in arch/arm/mach-tegra/usb_phy.c, contained in "utmip_defaults[]". I think I'm going to put those utmip_defaults[] stuff into tegra20.dtsi, and override them in tegra-seaboard.dts. How's that sound? And since there are defaults specified in tegra20.dtsi, does it really make sense to also have default values assigned in ehci-tegra.c (for when a property is not present)? I worry that the information is now duplicated. If those properties aren't present, then someone's mucked with the tegra20.dtsi ehci properties.-- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
