Re: [PATCH] usb: fix musb Kconfig

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 18, 2011 at 10:48:39PM +0530, Rabin Vincent wrote:
> On Mon, Jul 18, 2011 at 22:27, Felipe Balbi <balbi@xxxxxx> wrote:
> > On Mon, Jul 18, 2011 at 06:51:11PM +0530, Rabin Vincent wrote:
> >> --- a/drivers/usb/musb/Kconfig
> >> +++ b/drivers/usb/musb/Kconfig
> >> @@ -3,8 +3,8 @@
> >>  # for silicon based on Mentor Graphics INVENTRA designs
> >>  #
> >>
> >> -comment "Enable Host or Gadget support to see Inventra options"
> >> -     depends on !USB && USB_GADGET=n
> >> +comment "Enable Host and Gadget support to see Inventra options"
> >> +     depends on !USB || USB_GADGET=n
> >
> > you might as well remove this comment now that we're always compiling
> > with both Host and Peripheral sides enabled.
> 
> Hmm, what do you mean?  On current -next, I'm able to control CONFIG_USB
> and CONFIG_USB_GADGET independently, and the MUSB options only appear
> when both are enabled, and that's what the modified comment points out.

True, but I'm not sure it's really valid to have that comment always.
See that this comment will appear even on x86 which has no support for
MUSB.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux