>>>>> "Ionut" == Ionut Nicu <ionut.nicu@xxxxxxxxxxx> writes:
Ionut> Hi Uwe, On Wed, 2011-07-13 at 15:07 +0200, Uwe Bonnes wrote: *
Ionut> isn't encoding the first 16-bit half into urb_index wrong?
>> There are a lot of devices out there that work as expected, so we
>> can't be totally of...
>>
>> I tested with a real FT232H device and the algorithm in the FTDI, and
>> with setting the baudrate so that the divisor should change between
>> 2.0, 2.124, 2.25, ..., 3 I could see the bittime grow
>> continious. Fractional devide make the edge jitter as expected...
>>
>> So I am quite confident with the patch I sent.
Ionut> I just tested your patch and it worked also on my FT232H. Thanks!
Ionut> So, for 115200 bps, the calculated u32 divisor is: 0x2C068 which
Ionut> gets sent as urb_value = 0xc068 and urb_index = 0x200.
Ionut> I also agree with your previous post that the urb_index
Ionut> calculation (urb_index = (__u16)((urb_index << 8) |
Ionut> priv->interface)) is safe for all devices, so you can remove the
Ionut> switch statement.
Ionut> Can you send an updated patch?
As I explained, I won't touch the AM/BM code path, the the patch sent today
to this list and Greg still holds. B.t.w, it's no more switch, but serveal
if ||if ...
--
Uwe Bonnes bon@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt
--------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
