Re: [PATCH] usb: core: fix SuperSpeed bMaxPacketSize0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 12 Jul 2011, Felipe Balbi wrote:

> bMaxPacketSize0 on SuperSpeed devices should be 9 (2 ^ 9 == 512)
> 
> Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> --- 
> 
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index a428aa0..6964a28 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -2930,7 +2930,7 @@ hub_port_init (struct usb_hub *hub, struct usb_device *udev, int port1,
>  					buf, GET_DESCRIPTOR_BUFSIZE,
>  					initial_descriptor_timeout);
>  				switch (buf->bMaxPacketSize0) {
> -				case 8: case 16: case 32: case 64: case 255:
> +				case 8: case 9: case 16: case 32: case 64: case 255:
>  					if (buf->bDescriptorType ==
>  							USB_DT_DEVICE) {
>  						r = 0;

Unnecessary; this block of code is protected by a !(hcd->driver->flags
& HCD_USB3) test.  Besides, if this were really wrong then SuperSpeed
devices would never have worked under Linux.  :-)

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux