Re: [PATCH] usb: musb: omap2430: handle charger OTG xceiver event

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Jul 11, 2011 at 03:43:17PM -0700, Dima Zavin wrote:
> Set a flag on OTG charger event and check it on cable
> remove event (i.e. USB_EVENT_NONE). This way we will
> not need to power up the PHY when an external charger

s/PHY/LINK

> is detected by the transceiver itself.

... your logic is inversed. Link shouldn't be powered up to start with.
We should only power up the Link after we know it *will* be needed. The
way you're doing this is:

connect cable -> resume PHY -> resume Link -> if is_charger suspend
Link.

Where it should be:

connect cable -> resume PHY -> if is_charger goto done.

Now, to make a generic solution (which is what we want in the long run)
we still need a few changes on the OTG support and otg_transceiver on
Linux.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux