On Fri, 8 Jul 2011, Keshava Munegowda wrote:
> The usbhs core driver does not enable/disable the intefrace and
> fucntional clocks; These clocks are handled by hwmod and runtime pm,
> hence insted of the clock enable/disable, the runtime pm APIS are
> used. however,the port clocks and tll clocks are handled
> by the usbhs core.
> In this architecture, the usbhs is core driver and it is parent of
> ehci and ohci drivers.The earlier APIs omap_usbhs_enable and
> omap_usbhs_disable of usbhs core driver are removed;
> The ehci and ohci drivers call the pm_runtime_get_sync and
> pm_runtime_put_sync of parent device usbhs core.
> In fact, the runtime framework takes care the get sync and
> put sync of the child in turn call the get sync and put sync
> of parent too; but calling get sync and put sync of parent is
> by ASYNC mode; This mode queues the work item in runtime pm
> work queue, which not getting scheduled in case of global suspend path.
> so, here ehci and ohci runtim pm is not required, these
> drivers will pass the parent usbhs dev pointer in runtime pm APIs.
> --- a/drivers/usb/host/ohci-omap3.c
> +++ b/drivers/usb/host/ohci-omap3.c
> @@ -31,6 +31,7 @@
>
> #include <linux/platform_device.h>
> #include <plat/usb.h>
> +#include <linux/pm_runtime.h>
>
> /*-------------------------------------------------------------------------*/
>
> @@ -172,11 +173,7 @@ static int __devinit ohci_hcd_omap3_probe(struct platform_device *pdev)
> hcd->rsrc_len = resource_size(res);
> hcd->regs = regs;
>
> - ret = omap_usbhs_enable(dev);
> - if (ret) {
> - dev_dbg(dev, "failed to start ohci\n");
> - goto err_end;
> - }
> + pm_runtime_get_sync(dev->parent);
>
> ohci_hcd_init(hcd_to_ohci(hcd));
>
> @@ -189,7 +186,7 @@ static int __devinit ohci_hcd_omap3_probe(struct platform_device *pdev)
> return 0;
>
> err_add_hcd:
> - omap_usbhs_disable(dev);
> + pm_runtime_get_sync(dev->parent);
Looks like a typo; this should be _put_sync().
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
