On Sun, 26 Jun 2011, Tanya Brokhman wrote: > > > The above part is correct and IMO should be present similar to the > > #ifdef > > > CONFIG_GADGET_IS_DUALSPEED. It's not a "must" thought since the speed > > that > > > will be reported by the composite driver to the UDC is protected by > > this > > > feature flag. Look at usb_composite_probe() and at how the > > composite_driver > > > is defined. > > > > I disagree. The max_speed field is the maximum speed supported by the > > function driver. It has nothing to do with the speed the device is > > currently running at or the capabilities of the UDC hardware. > > > > There's no need for those #ifdef's and no reason to keep them. > > > > Then they should be removed from all the FD's, even those that don't support > SS at this point. Perhaps it's best to do it in a different commit than this > one...? Sure. But there's no reason to merge code that you know is going to be removed shortly. Avoid adding it in now for the Ethernet gadget, and take it out of the other drivers later in a separate patch. ALan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
