Hi Paul, > > Hi Tanya, > > OK, I didn't know about gadget_is_super_speed(), I will fix up and > resend. > > By the way, do you know if this part: > > .strings = dev_strings, > #ifdef CONFIG_USB_GADGET_DUALSPEED > +# ifdef CONFIG_USB_GADGET_SUPERSPEED > + .max_speed = USB_SPEED_SUPER, > +# else > .max_speed = USB_SPEED_HIGH, > +# endif > #else > .max_speed = USB_SPEED_FULL, > > is correct? Is the #ifdef CONFIG_USB_GADGET_SUPERSPEED necessary? Or > can I just set it to USB_SPEED_SUPER unconditionally, and the composite > framework will do the right thing? > The above part is correct and IMO should be present similar to the #ifdef CONFIG_GADGET_IS_DUALSPEED. It's not a "must" thought since the speed that will be reported by the composite driver to the UDC is protected by this feature flag. Look at usb_composite_probe() and at how the composite_driver is defined. Thanks, Tanya Brokhman --- Sent by an consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
