On Thu, 23 Jun 2011, Sergei Shtylyov wrote:
> Hello.
>
> On 22-06-2011 19:26, Marius B. Kotsbak wrote:
>
> > -Support for big endian.
> > -Do not use USB buffers at the stack.
> > -Safer/more efficient code for local constants.
>
> > Signed-off-by: Marius B. Kotsbak<marius@xxxxxxxxxxx>
> > ---
> > drivers/net/usb/kalmia.c | 40 ++++++++++++++++++++++++----------------
> > 1 files changed, 24 insertions(+), 16 deletions(-)
>
> > diff --git a/drivers/net/usb/kalmia.c b/drivers/net/usb/kalmia.c
> > index d965fb1..d4edeb2 100644
> > --- a/drivers/net/usb/kalmia.c
> > +++ b/drivers/net/usb/kalmia.c
> > @@ -100,27 +100,35 @@ kalmia_send_init_packet(struct usbnet *dev, u8 *init_msg, u8 init_msg_len,
> > static int
> > kalmia_init_and_get_ethernet_addr(struct usbnet *dev, u8 *ethernet_addr)
> > {
> > - char init_msg_1[] =
> > + const static char init_msg_1[] =
> > { 0x57, 0x50, 0x04, 0x00, 0x00, 0x00, 0x00, 0x20, 0x00, 0x00,
> > 0x00, 0x00 };
> > - char init_msg_2[] =
> > + const static char init_msg_2[] =
> > { 0x57, 0x50, 0x04, 0x00, 0x00, 0x00, 0x00, 0x02, 0x00, 0xf4,
> > 0x00, 0x00 };
>
> Actually 'const' alone should've been enough for the variable to be placed
> in the data section ISO stack.
I don't understand what "ISO stack" means here.
I would think that "const" might or might not cause the array to be
allocated statically. All it really tells the compiler is that the
function will not change the contents of the array.
To be certain that the array is allocated statically (not on the
stack), it's best to use "static".
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
