Alan Stern wrote:
On Wed, 22 Jun 2011, Sebastian Andrzej Siewior wrote:
* Alan Stern | 2011-06-22 10:31:47 [-0400]:
Whoa! Didn't we just have a discussion about all this stuff? Patches
3-5 in this series are inappropriate and should not be merged.
Why 4?. 3 and 5 disables the module parameter for SS. 4 just moves
things forward so it can be used for the new style probe. So this just
about 3 and 5 or is 4 also included?
Patch 4/8 unconditionally sets dum->gadget.speed = USB_SPEED_SUPER in
dummy_udc_probe() (misleading at best) and adds a call to
dummy_udc_udpate_ep0(). Neither of these appears to be necessary,
since dummy_pullup() will do those calculations over again.
I don't mind moving the code around. If the excess lines were removed,
patch 4 would be okay.
Okay, I take a look at it.
Regarding the module parameter for SS, would it be okay to change the
default to true since we plan to have 3.0 gadgets and leave it the
parameter testing purpose?
Alan Stern
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
