Re: [PATCH 1/2] gpio-vbus: support disabling D+ pullup on suspend

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, Jun 22, 2011 at 06:26:36PM +0400, Dmitry Eremin-Solenikov wrote:
> >You could use osme VBUS IRQ to toggle a driver flag which, if true,
> >would return -EBUSY on suspend().
> 
> I'm more and more thinking that this handling this -EBUSY isn't a
> task of gpio-vbus, but rather of some higher level driver. I'd assume
> that
> if I hit this point, all previous drivers (which depend on this
> transceiver, so registered later) permit suspending at this moment,
> so everything is OK :)

the thing is that today we don't have the "higher level driver" see that
the OTG/transceiver framework (if you can call it a framework) is just a
static global pointer which people set. So, you need to have
per-transceiver solutions, unfortunately :-(

> >>I agree with you generally, but I'd like to hear any suggestions.
> >
> >I'm not sure how to solve this, but OTOH the original code already did
> >this, just on a different way, right ?
> 
> Yes. pxa27x udc driver disables D+ pullup on suspend and that's the
> behaviour asked from me by Robert Jarzmik in comments to first
> cleanup patch serie for pxa27x UDC driver.

ok... so, go ahead but keep in mind you could end up in a bad situation
;-)

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux