Hi, On Tue, Jun 21, 2011 at 03:53:42PM +0300, Tanya Brokhman wrote: > > > > > > Agreed, but the above should be accomplished by setting the > > is_super_speed > > > parameter default value to TRUE, not by always registering SS hcd. It > > seems > > > a bit difficult to argue with the fact that if is_super_speed=false > > SS HCD > > > will never be used :) thus it seems logical not to register it as > > well. > > > > Well, it only makes sense if we want to keep this option to force the > > udc > > to certain speed which less than what it would choose by itself. > > And then the question poped if we want to have global knob for it or > > not. > > I think this option is very useful when developing SS gadgets. For example - > I used it a lot when working on UAS gadget driver. Actually, still do :) Yeah, but we're planning on start converting the gadget drivers and, I don't know about you guys, but I like modules which just work without user having to modinfo <modulename> before loading it. So I'm planning on applying this on this merge window and add the ->set_speed() stuff on the next one. That will be a more generic solution which should work for all controllers (as long as user implements ->set_speed()), not only dummy_hcd. -- balbi
Attachment:
signature.asc
Description: Digital signature
