Hi, On Tue, Jun 21, 2011 at 01:28:19PM -0400, Alan Stern wrote: > On Tue, 21 Jun 2011, Sebastian Andrzej Siewior wrote: > > > Alan Stern wrote: > > > On Tue, 21 Jun 2011, Sebastian Andrzej Siewior wrote: > > > > > >> Felipe pointed out automated testing. Since a script can't use a different > > >> cable wouldn't it be nice to have a central knob for that? > > > > > > Maybe a common module parameter. I don't think you want to change the > > > speed once the UDC has started running. > > > > The sysfs file could be limited to only accept a parameter if the udc is > > not bound. So what is left is something for the built-in case. And here I > > think having the command line switch implemented in udc-core instead of in > > every driver. > > Well, you could put the sysfs attribute definition (or module parameter > definition, since module parameters also show up in sysfs and can be > writable) in udc-core. But the actual implementation of the speed > parameter would obviously have to go in the individual UDC drivers. true. I mentioned before we would need some sort of ->set_speed() operation on usb_gadget_ops. -- balbi
Attachment:
signature.asc
Description: Digital signature
