On Mon, Jun 20, 2011 at 01:35:35PM -0400, Alan Stern wrote: > According to Arnd, any remaining possible issues will be addressed by > changing the implementation of readl/writel on ARM. It doesn't look as > though the ehci files need anything else done. I'm not about to change their implementation because they've proven themselves over the last 10 years to be perfectly fine, and changing them has a habbit of causing GCC to play less optimally than it should do. I've seen drivers where GCC reloads the base address from the driver private data structure each time a register access is performed, rather than caching the base address in a register. I've seen it issuing separate add instructions and using a zero pre-index load/store. The existing way is the only way I've found to get GCC to come anywhere close to producing "optimal" code for the IO accessors. If it is the case that these structures do not require packing to get their desired layout, then they don't require packing, and the packed attribute should be dropped. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
