On Sat, Jun 11, 2011 at 01:34:30AM +0200, Marius B. Kotsbak wrote: > Introducing driver for the network port of Samsung Kalmia based USB LTE modems. > It has also an ACM interface that previous patches associates with the "option" > module. To access those interfaces, the modem must first be switched from modem > mode using a tool like usb_modeswitch. Do we need to blacklist this device from the option driver? We can do that easily then you don't need a usb_modeswitch change, right? > As the proprietary protocol has been discovered by watching the MS Windows driver > behavior, there might be errors in the protocol handling, but stable and fast > connection has been established for hours with Norwegian operator NetCom that > distributes this modem with their LTE/4G subscription. > > More and updated information about how to use this driver is available here: > > http://www.draisberghof.de/usb_modeswitch/bb/viewtopic.php?t=465 > https://github.com/mkotsbak/Samsung-GT-B3730-linux-driver > > Signed-off-by: Marius B. Kotsbak <marius@xxxxxxxxxxx> Very nice job, one minor comment nit: > +/* > + * USB network interface driver for Samsung Kalmia based LTE USB modem like the > + * Samsung GT-B3730 and GT-B3710. > + * > + * Copyright (C) 2011 Marius Bjoernstad Kotsbak Email address after your name? > + * > + * Sponsored by Quicklink Video Distribution Services Ltd. > + * > + * Based on the cdc_eem module. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. Do you really mean "any later version"? > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA These two paragraphs are not needed, and unless you want to track the FSF's office changes for the next 40+ years, I'd really suggest not putting it in there at all. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
