On Sat, 11 Jun 2011 00:11:17 +0200, Felipe Balbi <balbi@xxxxxx> wrote:
I'm suggesting that we don't need two implementations for the same thing, see that when g_ether was converted to composite.c, its functions were phased out to f_ecm.c, f_ether.c and f_subset.c and the old ether.c became just a simple layer to tie things up together. Why was g_file_storage done differently, I don't know ;-)
Well, because... uhm... Nice whether outside, isn't it? ;)
So, if we have "removable" set to one, we connect straight away, but if we don't there's no reason to connect to host until we have the backing file opened. So, if we fail opening the backing file, we shouldn't even connect to host IMHO.
g_file_storage and g_mass_storage both fail to load if removable=0 and file was not specified or code could not open it. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michal "mina86" Nazarewicz (o o) ooo +-----<email/xmpp: mnazarewicz@xxxxxxxxxx>-----ooO--(_)--Ooo-- -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
