On Mon, 6 Jun 2011, Christoph Fritz wrote: > According to chapter 9.3 of USB specification 2.0, bmRequestTypes order > of fields is: > - bit 0 to 4 recipient > - bit 5 to 6 type > - bit 7 data transfer direction That's not the _order_ of the fields -- it's the _location_ of the fields. If you read the fields from left to right (the normal direction in English although not in some other languages), the order is: direction, type, recipient. That's also the order in which the fields are listed in the ch9.h file. > Signed-off-by: Christoph Fritz <chf.fritz@xxxxxxxxxxxxxx> > --- > include/linux/usb/ch9.h | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/usb/ch9.h b/include/linux/usb/ch9.h > index b72f305..09cf912 100644 > --- a/include/linux/usb/ch9.h > +++ b/include/linux/usb/ch9.h > @@ -43,7 +43,7 @@ > * USB directions > * > * This bit flag is used in endpoint descriptors' bEndpointAddress field. > - * It's also one of three fields in control requests bRequestType. > + * It's also the third of three fields in control requests bRequestType. > */ > #define USB_DIR_OUT 0 /* to device */ > #define USB_DIR_IN 0x80 /* to host */ > @@ -58,7 +58,7 @@ > #define USB_TYPE_RESERVED (0x03 << 5) > > /* > - * USB recipients, the third of three bRequestType fields > + * USB recipients, the first of three bRequestType fields > */ > #define USB_RECIP_MASK 0x1f > #define USB_RECIP_DEVICE 0x00 This change seems quite unnecessary. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
