Hi, On Tue, May 31, 2011 at 04:18:24PM +0300, Tatyana Brokhman wrote: > This field is used by the Gadget drivers to specify the maximum speed > they support, meaning: the maximum speed they can provide descriptors for. > > The driver speed will be set in consideration of this value. > > Signed-off-by: Tatyana Brokhman <tlinder@xxxxxxxxxxxxxx> personally, I don't think this is good enough. The gadget speed is actually the min() of the f_* speeds. So, IMHO this should be coming from f_* and during bind you would: gadget->speed = min(f->speed, gadget->speed); for all functions. Also, both this patch and what I described above, only works considering nobody touches that enum, so we might want to be careful and add some comments to the enum to avoid anyone from touching that :-) -- balbi
Attachment:
signature.asc
Description: Digital signature
